refactor: rename bundled server_config.json to example#233
Open
refactor: rename bundled server_config.json to example#233
Conversation
axisrow
force-pushed
the
refactor/example-server-config
branch
3 times, most recently
from
18108d0 to
6009d1c
Compare
…er tests - Rename src/mcp_cli/server_config.json to server_config.example.json - Remove bundled config fallback logic from ConfigLoader - Migrate all hardcoded "server_config.json" to DEFAULT_CONFIG_FILENAME constant - Raise missing-config log level from DEBUG to INFO for better user visibility - Fix webbrowser.open patch targets in dashboard launcher tests - Update ConfigLoader FileNotFoundError tests with strict assertions and caplog Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
axisrow
force-pushed
the
refactor/example-server-config
branch
from
6009d1c to
a7d6b25
Compare
…aults - Rename server_config.json to server_config.example.json to clarify it's a template - Fix launcher tests to use the new example config path - Align default provider/model with README (ollama/gpt-oss) - Update OpenAI models to current lineup (GPT-5.2, GPT-4.1, o4-mini, o3-pro) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
axisrow
force-pushed
the
refactor/example-server-config
branch
from
88841c7 to
ee6cdfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server_config.json→server_config.example.jsonso it is no longer auto-loaded as a fallback (eliminates token warnings for 18+ unconfigured servers)cp server_config.example.json server_config.jsonopenai/gpt-4o-mini→ollama/gpt-ossacrossdefaults.py,main.py, andrun_command.pyChatContext.clientnow returnsNoneinstead of crashing when the API key is missingconfig_loader.pyTest plan
mcp-cli --helpwithoutserver_config.json— no warnings should appearserver_config.json, runmcp-cli --server sqlite— works as before--debugflag — "Config file not found" appears at DEBUG level only--provider/--modelflags — defaults toollama/gpt-oss🤖 Generated with Claude Code